[Offload] Change section names for offload entries #20509
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow the community change that renames the section for the offload entries from omp_offloading_entries to llvm_offload_entries.
hansangbae
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
hansangbae
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
hansangbae
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
hansangbae
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
hansangbae
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
hansangbae
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
YuriPlyakhin
approved these changes
Oct 30, 2025
|
@YuriPlyakhin I am not authorized to merge. Can you merge this change if possible? |
@hansangbae , you are missing approval from @intel/dpcpp-clang-driver-reviewers yet. |
srividya-sundaram
approved these changes
Oct 30, 2025
fzou1
reviewed
Nov 3, 2025
| ConstantAggregateZero::get(ArrayType::get(getEntryTy(), 0u)); | ||
| auto *DummyEntry = new GlobalVariable( | ||
| M, DummyInit->getType(), true, GlobalVariable::ExternalLinkage, | ||
| DummyInit, "__dummy.omp_offloading.entry"); |
There was a problem hiding this comment.
Should the __dummy.omp_offloading.entry be renamed to __dummy.llvm_offload.entry too?
There was a problem hiding this comment.
No, the name change is only for omp_offloading_entries -> llvm_offload_entries.
There was a problem hiding this comment.
No, the name change is only for
omp_offloading_entries->llvm_offload_entries.
Okay. Thanks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow the community change that renames the section for the offload entries from omp_offloading_entries to llvm_offload_entries.